Potential Offer Handling

lndk-org / lndk

MIT License

76 stars 19 forks source link

Potential Offer Handling #85

Closed carlaKC closed 6 months ago

carlaKC commented 7 months ago

Opening up to express some ideas around how we'd handle #81 and #84, not intended for merge.

We've already got a lot of the machinery in place to handle the onion messaging side of things in LDK, so I'd like to try to take advantage of that - if we provide an OfferMessageHandler that correctly queues messages, the existing onion messenger will drive sending / notifying of onion messages. That leaves our code responsible for:

Creating an invoice request and adding it to the handler's existing queue
Handling the invoice that comes back (validating it vs the original request / amount)
Tracking state to make sure we don't process anything twice

Hope that this adds some context to the review!

codecov[bot] commented 7 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (41a226c) 0.00% compared to head (e3c58c5) 0.00%. Report is 2 commits behind head on master.

Files	Patch %	Lines
src/main.rs	0.00%	5 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #85 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 1 1 Lines 12 16 +4 ====================================== - Misses 12 16 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

orbitalturtle commented 7 months ago

@carlaKC Ahh yup this makes sense to me, I think. I'll refactor with this (or something like it) as the base.

carlaKC commented 6 months ago

Closing this out as it was just an example- @orbitalturtle feel free to take this over / squash your changes as needed.