search

lndk-org / lndk

MIT License
76 stars 19 forks source link

Offers: send invoice request #87

Closed orbitalturtle closed 4 months ago

orbitalturtle commented 6 months ago

Rewrote the send invoice logic with #85 in mind. I agree it seems cleaner :) I realize #85 wasn't intended for merge, but I didn't need to make many significant changes to the structure, so I just made a few tweaks to the commits here.

Also about to write a few thoughts/questions inline.

Replaces #81.

orbitalturtle commented 6 months ago

It looks like the clippy error is coming from configure_me.

carlaKC commented 6 months ago

I realize https://github.com/lndk-org/lndk/pull/85 wasn't intended for merge, but I didn't need to make many significant changes to the structure, so I just made a few tweaks to the commits here.

Happy for you to add those as fixups to the original commits + squash and you can just take it over 👍 ie, we merge what's in #85 in here

orbitalturtle commented 5 months ago

@carlaKC Sounds good, I like option 2. I can see what you're saying above about modularity and I'd be down to switch to your approach. But I like the idea of merging it as is (once we have e2e working, etc), then going back to refactor. Going back and interactive rebasing that big of a change sounds like a royal pain and I'd love to avoid it if possible, ha ha.