Does lndk still need a custom branch of LND?

[niteshbalusu11]

In the readme it says to run a custom branch and add this to the conf file.

[protocol]
protocol.custom-message=513
protocol.custom-nodeann=39
protocol.custom-init=39

LND now has this API, can lndk rely on this instead?

https://lightning.engineering/api-docs/api/lnd/peers/update-node-announcement

[niteshbalusu11]

Hmm looks like people still have to compile LND with dev flag because of this:

this is in the lnd docs.

Message type. This value needs to be in the custom range (>= 32768). To send a type < custom range, lnd needs to be compiled with the `dev` build tag, and the message type to override should be specified in lnd's experimental protocol configuration.

and then there is this.

/// ONION_MESSAGE_TYPE is the message type number used in BOLT1 message types for onion messages.
const ONION_MESSAGE_TYPE:u32 = 513;

[orbitalturtle]

Oh yup we need to update the docs, lndk should work with the latest versions of LND (v17+), no custom branch needed. But iirc you'll still need to add those protocol config options to the conf file - @carlaKC will be more sure on that last part.

[niteshbalusu11]

It's still annoying that you have to compile with dev flag though else type 513 won't be supported by LND. And nobody will compile with dev flag manually for production builds.

[carlaKC]

It's still annoying that you have to compile with dev flag though else type 513 won't be supported by LND.

Indeed, but the dev flag in LND is there to gate this type of advanced functionally with good reason IMO.

And nobody will compile with dev flag manually for production builds.

That's out of our control as a project, sadly. If you want to run experimental software (LNDK), you're going to have to do some experimental things (dev tag), I don't see any getting around that.

[carlaKC]

Thanks for pointing out that the docs are out of date (my absolute worst pet peeve that I'm always guilty of ☠️ ), fixed by #95.

[orbitalturtle]

Re: the dev flag issue: https://github.com/lightningnetwork/lnd/pull/8744