Open zhengliuer opened 2 years ago
Hi Barry,
I'm impressed that you were able to use my code at all. It's still in a preliminary state so I didn't think anybody else would be able to do much with it.
You are correct that my EI calculation does not match the results from AnyWave. Understanding why is on my to do list but I have not been able to find the code that AnyWave uses to perform the calculation.
Larry
From: 刘政(Barry Liu) @.> Sent: Friday, December 24, 2021 7:14 AM To: lneisenman/seeg @.> Cc: Subscribed @.***> Subject: [lneisenman/seeg] Is EI result consistent with the result of AnyWave? (Issue #1)
Hi, I'm Barry. First of all, Greate repo for calculating EI! I've tried the code in this repo. and the AnyWave EI calculation. The result is different. May I ask is your data's EI result consistent with AnyWave? Or I did something wrong.
― Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flneisenman%2Fseeg%2Fissues%2F1&data=04%7C01%7C%7C832c9c4ff17747f4daba08d9c6df4be6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637759484616100064%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=YyA9AXAr5XSYErC3rA6yt%2FYsld3OVucvruPs997iVbc%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACIMUWIXCGRTW264TWHPRMDUSRW2XANCNFSM5KWTYPSQ&data=04%7C01%7C%7C832c9c4ff17747f4daba08d9c6df4be6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637759484616100064%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=UHYRLiCvcHnNQAOoSdQJ0Pb6UArAutFrZbidNqlsCLI%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C832c9c4ff17747f4daba08d9c6df4be6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637759484616100064%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=7D5aOt6d6NBlxXkvO33T%2B25gkFwi%2FWIoUW8CElOBdO4%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C832c9c4ff17747f4daba08d9c6df4be6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637759484616100064%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Z77IFbYc9Q6rpwSgs4PIeuXSnLQAABNv8vOi5TQa6ME%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>
AnyWave's EI calculation is based on MATLAB and is not open-source. Here is a PDF that the developer of AnyWave gave. https://drive.google.com/file/d/15N5H7UYH7s8Q02bGuygI_VtlRd452r0Z/view?usp=sharing Actually, I had a quick view of your code and didn't see any procedure not consistent with the PDF. I would currently compare the result of these two ways to calculate EI with the clinical result. closed-source codes are always disturbing.
Thanks for the link. Without seeing their code, it is difficult to figure out why the results are different. It could easily be a bug but it could also be something like a subtle difference in how the FFTs are calculated in Matlab vs Python.
Larry
From: 刘政(Barry Liu) @.> Sent: Friday, December 24, 2021 12:54 PM To: lneisenman/seeg @.> Cc: lneisenman @.>; Comment @.> Subject: Re: [lneisenman/seeg] Is EI result consistent with the result of AnyWave? (Issue #1)
AnyWave's EI calculation is based on MATLAB and is not open-source. Here is a PDF that the developer of AnyWave. https://drive.google.com/file/d/15N5H7UYH7s8Q02bGuygI_VtlRd452r0Z/view?usp=sharinghttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrive.google.com%2Ffile%2Fd%2F15N5H7UYH7s8Q02bGuygI_VtlRd452r0Z%2Fview%3Fusp%3Dsharing&data=04%7C01%7C%7C2234faec30994f5c5d7308d9c70ed6dd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637759688824082731%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=9V3m%2FpHm1VSUKQTVbdsX0xTibjvf2nxfvfivjnzevm0%3D&reserved=0 Actually, I have a quick view of your code and didn't see any procedure not consistent with the PDF. I would currently compare the result of these two ways to calculate EI with the clinical result.
― Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flneisenman%2Fseeg%2Fissues%2F1%23issuecomment-1000916301&data=04%7C01%7C%7C2234faec30994f5c5d7308d9c70ed6dd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637759688824082731%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=N9OQwHf4vhhd%2BkrwYvLbbriNY92l%2FdffxRdCwgl7RrE%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACIMUWKW7CGT2YIENOA26TTUSS6W5ANCNFSM5KWTYPSQ&data=04%7C01%7C%7C2234faec30994f5c5d7308d9c70ed6dd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637759688824082731%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=yOTnGgJZzn5ynUlCbWqEnW3NBq595JGld5JUaFCZNqc%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C2234faec30994f5c5d7308d9c70ed6dd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637759688824082731%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=rZcrC8F15okx1BSKujEGzKV3rNT6RhcYaRMESkkwJ5Y%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C2234faec30994f5c5d7308d9c70ed6dd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637759688824082731%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=IHUiNUNC8YskmAtqgsjoQXqIUyzDPHfYYZscFa7cDv4%3D&reserved=0. You are receiving this because you commented.Message ID: @.***>
Hi, I just contacted EI developer, the source code is not available. About the PSD calculation, they used a short-time Fourier transform, might consider to use the same way to calculate PSD.
Thanks for the follow up
Larry
From: 刘政(Barry Liu) @.> Sent: Wednesday, January 5, 2022 10:12 AM To: lneisenman/seeg @.> Cc: lneisenman @.>; Comment @.> Subject: Re: [lneisenman/seeg] Is EI result consistent with the result of AnyWave? (Issue #1)
Hi, I just contacted EI developer, the source code is not available. About the PSD calculation, they used a short-time Fourier transform, might consider to use the same way to calculate PSD.
― Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flneisenman%2Fseeg%2Fissues%2F1%23issuecomment-1005863780&data=04%7C01%7C%7Cafd21f713199493d39b408d9d0661fd8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637769959318873648%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=H1lxFXFhBTAsYhBIJQn1Z7HBQuE9S0S9KDMFRBxNPmQ%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACIMUWI7KQRVJYC4RL2YZ3TUURUVRANCNFSM5KWTYPSQ&data=04%7C01%7C%7Cafd21f713199493d39b408d9d0661fd8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637769959318873648%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=tJnoai5xOY8FDIMesgAfkWONHez7%2F9mY5JqDl971w7o%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Cafd21f713199493d39b408d9d0661fd8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637769959318873648%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=p0YiSr4OZuGoMrkYbFDSTSTcxAbYev9F5ixFxVjxiok%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Cafd21f713199493d39b408d9d0661fd8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637769959318873648%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=yMSGPBZdauVmXCAAuMhMAvX6gJ5HDP0IP2xb8bXC2Ao%3D&reserved=0. You are receiving this because you commented.Message ID: @.***>
Hi, I'm Barry. First of all, Greate repo for calculating EI! I've tried the code in this repo. and the AnyWave EI calculation. The result is different. May I ask is your data's EI result consistent with AnyWave? Or I did something wrong.