search

lneugebauer / nextcloud-cookbook

Android client for Nextcloud Cookbook app.
https://lneugebauer.github.io/nextcloud-cookbook/
MIT License
46 stars 8 forks source link

Login Screen - URL checking #59

Closed AndusDEV closed 9 months ago

AndusDEV commented 10 months ago

Most of Android keyboards replace "https" with "HTTPS" if you have autocorrect enabled. It happened to me and I had to replace it to lowercase for it to work. This commit just adds ".toLowerCase()" to the checks In LoginViewModel.kt.

lneugebauer commented 9 months ago

Hi @AndusDEV, thank you for your contribution - much appreciated. I agree that the isValidUrl check should be successful whether its https or HTTPS. However, please undo the other changes, as the user may have a case sensitive server setup and I don't wanna mess with that.

AndusDEV commented 9 months ago

@lneugebauer I've just reverted the second commit. It should be good to go now

lneugebauer commented 9 months ago

@AndusDEV please fix the ktlint issues. After that I'll merge the pr.

AndusDEV commented 9 months ago

@lneugebauer I've just realised I used a completely wrong function. I fixed it now, the build is successing, and running just fine