lneuhaus / pyrpl

pyrpl turns your RedPitaya into a powerful DSP device, especially suitable as a lockbox in quantum optics experiments.
http://lneuhaus.github.io/pyrpl/
MIT License
139 stars 109 forks source link

Develop 0 9 3 #330

Closed SamuelDeleglise closed 4 years ago

SamuelDeleglise commented 6 years ago

Input outputs in housekeeping work both ways...

I will also try to make a widget for the HK

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4cb6903). Click here to learn what that means. The diff coverage is 23.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #330   +/-   ##
=========================================
  Coverage          ?   33.41%           
=========================================
  Files             ?       99           
  Lines             ?    11703           
  Branches          ?        0           
=========================================
  Hits              ?     3911           
  Misses            ?     7792           
  Partials          ?        0
Impacted Files Coverage Δ
pyrpl/widgets/module_widgets/base_module_widget.py 25.4% <ø> (ø)
pyrpl/software_modules/lockbox/lockbox.py 30.43% <ø> (ø)
pyrpl/acquisition_module.py 35.86% <ø> (ø)
pyrpl/software_modules/lockbox/stage.py 48.68% <ø> (ø)
pyrpl/hardware_modules/asg.py 49.06% <ø> (ø)
...yrpl/software_modules/lockbox/models/fabryperot.py 35.75% <ø> (ø)
...idgets/module_widgets/acquisition_module_widget.py 15.78% <ø> (ø)
pyrpl/hardware_modules/iir/__init__.py 100% <ø> (ø)
pyrpl/widgets/module_widgets/__init__.py 100% <ø> (ø)
pyrpl/widgets/module_widgets/na_widget.py 14.79% <ø> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cb6903...2a995e4. Read the comment docs.

SamuelDeleglise commented 5 years ago

Sorry for the persistent bugs with pyrpl_async. It's a real pain in the #.*@ to debug this in all python versions. I believe that your bugfix for python3.6 was still causing some troubles. It looks like it should be OK now in 87cd3f152b84cf3a7be26b1e93a34aa91cf6681e. At least, now in python3.6:

lneuhaus commented 4 years ago

This is way too old, I'll close this and we'll open another one.