search

lnferris / ocean_data_tools

A MATLAB toolbox for interacting with bulk freely-available oceanographic data.
MIT License
83 stars 24 forks source link

Revise or remove more_colors #13

Closed kakearney closed 4 years ago

kakearney commented 4 years ago

This issue is part of the JOSS review (openjournals/joss-reviews#2497)

The more_colors function should be eliminated. It changes the user's default color order at the Matlab root level. This is very undesireable behavior; functions should never alter user preferences like this, especially without warning (this function is undocumented and called from within other plotting functions). There are far better ways to change the color of plotted lines, e.g. setting colors of specific line objects manually via set(), altering the color order of a single specific axis, etc.

lnferris commented 4 years ago

Thanks for the explanation. I have eliminated more_colors().