lnflash / charts

Flash fork of Galoy helm charts
MIT License
2 stars 1 forks source link

add caribbean currencies #17

Closed islandbitcoin closed 7 months ago

islandbitcoin commented 7 months ago

If I understand correctly, this change only adds price data to the UI? It does not allow users to denominate their account in another currency?

Also, do you know if this backfills with historical price data for each of these currencies? or does this just allow querying for current price data?

correct. its just a display currency. Their wallets will always be denominated in USD or BTC.

It does not backfill for historical price, this is only for real-time conversion on the Home Screen. The historical chart is in USD.

islandbitcoin commented 7 months ago

I don't think I have the format correct for realtime.config

brh28 commented 7 months ago

What documentation have you seen for this? How did you know to update Values.realtime.config with the values provided?

brh28 commented 7 months ago

Pod is failing in the dev environment with:

ConfigError: Invalid yaml configuration
    at Object.<anonymous> (/app/config/yaml.js:53:11)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19)
    at require (node:internal/modules/helpers:130:18)
    at Object.<anonymous> (/app/config/index.js:19:14)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10) {
  data: [
    {
      instancePath: '',
      schemaPath: '#/additionalProperties',
      keyword: 'additionalProperties',
      params: { additionalProperty: '0' },
      message: 'must NOT have additional properties'
    }
  ]
}
brh28 commented 7 months ago

What documentation have you seen for this? How did you know to update Values.realtime.config with the values provided?

From Arvin at Galoy:

Yup that's a price server thing
https://t.co/oajegdSByI
From github.com
This is the relevant config here in the repo
https://t.co/Pi4QPw16Nz
From github.com
And I think we inject all our currencies via an override of this entry in charts
❤️

thx man