search

lngyeen / MySurveyChallenge

0 stars 0 forks source link

Start of the code review process 👋 #23

Closed blyscuit closed 4 months ago

blyscuit commented 4 months ago

Hello Nguyễn Trường Lưu 👋 , thank you for your effort on the code submission. I am Bliss, Senior Software Engineer at Nimble, and I am happy to be the reviewer for our code review session.

During the review process, I would like to know more about your decisions, so I will create issues in some areas where there could be more improvements regarding your submission. Since solving every possible problem would take too long, I will prioritize the most important ones.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.

We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.

If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Just so you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇

In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘

blyscuit commented 4 months ago

I have completed the first round of reviews. Please provide your feedback on all open issues. Issues priority are arranged by creation time, lower id is higher priority.

lngyeen commented 4 months ago

Hello @blyscuit Thank you for taking the time to review. I will review and respond to you soon. :)

blyscuit commented 4 months ago

Good morning Nguyễn Trường Lưu,

Thank you for your timely updates! As of now, my review for this code challenge session has concluded, and thus no more submissions will be needed from your end.

For the next step, you will hear from the Talent Acquisition team about the decision as soon as we complete the evaluation.