search

lni / dragonboat

A feature complete and high performance multi-group Raft library in Go.
Apache License 2.0
5.06k stars 541 forks source link

dragonboat: NodeDeleted event #247

Closed uber42 closed 2 years ago

uber42 commented 2 years ago

When deleting a node, it stops as if it just terminates and the node itself does not know that it was deleted.

For example, we want to stop a node in systemd after deletion with exitcode such that it does not restart, but in the current case there is no difference between deletion and termination.

Perhaps there are some other workarounds for this? I would like to avoid unnecessary proposals before removing the node from the raft.

lni commented 2 years ago

Thanks for the PR. will review during the last week of July. Sorry for the delay - was out of town.

lni commented 2 years ago

Thanks for the PR. It looks good to me, merged.

In case you have noticed, Dragonboat's next release will be a v4 release with breaking changes to its public APIs. I'd expect such change to have minimal impacts on existing users and I estimate that most users would spend less than 15 minutes on necessary changes required for adopting the v4.

uber42 commented 2 years ago

Thanks! Could you tell when v4 will be released?