Closed coufalja closed 1 year ago
@coufalja thanks for the PR.
Just a quick question, is there any particular reason to use a pebble reversion that is just a few days old? Will the release version used by the cockroachdb meet your feature requirements while also being more reliable? e.g. the one in their release 22.1 branch -
https://github.com/cockroachdb/pebble/commits/crl-release-22.1
@lni Good question, you are right. I am in need of crl-release-22.2 if that is OK with you.
@coufalja
crl-release-22.2 sounds like a very reasonable choice. Could you please just update your PR to use crl-release-22.2? Thanks.
@lni I already did 😉
Cool, thanks again for the PR.
@coufalja you may also want to have a look at the new raft log storage engine known as tan, it is available at -
https://github.com/lni/dragonboat/tree/master/internal/tan
it is derived from pebble code, but significantly faster than the pebble. unfortunately, data format is completely different and there is no data migration tool atm. I'd recommend people starting new projects to use tan.
moving forward, both tan the existing pebble based storage will be supported.
Codecov Report
Base: 84.57% // Head: 84.64% // Increases project coverage by
+0.08%
:tada:Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #265 +/- ## ========================================== + Coverage 84.57% 84.64% +0.08% ========================================== Files 10 10 Lines 4264 4264 ========================================== + Hits 3606 3609 +3 + Misses 402 400 -2 + Partials 256 255 -1 ``` | [Impacted Files](https://codecov.io/gh/lni/dragonboat/pull/265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lni) | Coverage Δ | | |---|---|---| | [request.go](https://codecov.io/gh/lni/dragonboat/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lni#diff-cmVxdWVzdC5nbw==) | `93.16% <0.00%> (-0.46%)` | :arrow_down: | | [engine.go](https://codecov.io/gh/lni/dragonboat/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lni#diff-ZW5naW5lLmdv) | `84.07% <0.00%> (+0.23%)` | :arrow_up: | | [node.go](https://codecov.io/gh/lni/dragonboat/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lni#diff-bm9kZS5nbw==) | `79.99% <0.00%> (+0.29%)` | :arrow_up: | | [event.go](https://codecov.io/gh/lni/dragonboat/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lni#diff-ZXZlbnQuZ28=) | `64.62% <0.00%> (+0.77%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lni). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lni):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.