search

lni / dragonboat

A feature complete and high performance multi-group Raft library in Go.
Apache License 2.0
5.09k stars 542 forks source link

Make dragonboat work with Pebble v1.0.0 #339

Closed tylerwilliams closed 10 months ago

tylerwilliams commented 11 months ago

(Based off of https://github.com/lni/vfs/pull/3)

lni commented 11 months ago

Could you please have a look at the above failed tests? The go version might need to be bumped to go 1.21, there seem to be other issues as well.

Thanks.

tylerwilliams commented 11 months ago

Could you please have a look at the above failed tests? The go version might need to be bumped to go 1.21, there seem to be other issues as well.

Thanks.

I'm having a difficult time making these tests pass without the vfs library change being committed. Could you take a look at that one first?

tylerwilliams commented 11 months ago

Could you please have a look at the above failed tests? The go version might need to be bumped to go 1.21, there seem to be other issues as well. Thanks.

I'm having a difficult time making these tests pass without the vfs library change being committed. Could you take a look at that one first?

Ah, please ignore my last comment. I see this is down to a mac v linux issue. Will take a look tomorrow if I get time.

mostcute commented 11 months ago

it's just rand pkg changed since go1.20.0

lni commented 11 months ago

Thanks @mostcute.

I guess we can just bump the required Go version to v1.20.

lni commented 11 months ago

I've bumped dragonboat's required go version to v1.20.

@tylerwilliams would you like to merge master into your branch and give it a go? Thanks.

tylerwilliams commented 10 months ago

closing in favor of https://github.com/lni/dragonboat/pull/341