added sd_watchdog_enabled (#1)

lnicola / sd-notify

Apache License 2.0

43 stars 6 forks source link

added sd_watchdog_enabled (#1) #6

Closed JanZachmann closed 2 years ago

JanZachmann commented 2 years ago

added watchdog_enabled function
added tests

lnicola commented 2 years ago

Sorry, I kinda' forgot about this. I left a couple of remarks, but it's fine if you can't update the PR right now. I can merge it as-is today or tomorrow and fix these up in a later commit.

JanZachmann commented 2 years ago

Sorry, I kinda' forgot about this. I left a couple of remarks, but it's fine if you can't update the PR right now. I can merge it as-is today or tomorrow and fix these up in a later commit.

I really would like to come back to your offer to merge and fix later on.

lnicola commented 2 years ago

Sure, and thanks!

JanZachmann commented 2 years ago

Sure, and thanks!

You're welcome! When can I expect a new release on crates.io or a new git tag I can reference in my code?

lnicola commented 2 years ago

In the next day or two. I'm somewhat worried about the return type, it should use a custom error enum, but the other methods return std::io::Result, which is a bit ugly.

JanZachmann commented 2 years ago

In the next day or two. I'm somewhat worried about the return type, it should use a custom error enum, but the other methods return std::io::Result, which is a bit ugly.

Hi. Any news about releasing to crates.io?

lnicola commented 2 years ago

Yeah, sorry, I'm this great at keeping deadlines.

I've just made the changes mentioned above and released the new version (0.4.1).

JanZachmann commented 2 years ago

Yeah, sorry, I'm this great at keeping deadlines.

I've just made the changes mentioned above and released the new version (0.4.1).

Thx