search

lnis-uofu / SOFA

SOFA (Skywater Opensource FPGAs) based on Skywater 130nm PDK and OpenFPGA
https://skywater-openfpga.readthedocs.io/en/latest/
MIT License
131 stars 27 forks source link

Merging registered/non-registered related IO definition in k4_N8 device #86

Closed sharmaln closed 3 years ago

sharmaln commented 3 years ago

@tangxifan : need your review comments specifically on openfpga xml file. @tpagarani : has reviewed both xml but require you to review openfpga.xml. In openfpga xml file, at line no 410, cin_mux is defined but in vpr_arch xml, there is no mux defined with the same name. I even looked at openfpga.log file but didn't see any warning/error for this one. So, is it not really an issue if mux names are not matching in these two files for specific connections.

tangxifan commented 3 years ago

@tangxifan : need your review comments specifically on openfpga xml file. @tpagarani : has reviewed both xml but require you to review openfpga.xml. In openfpga xml file, at line no 410, cin_mux is defined but in vpr_arch xml, there is no mux defined with the same name. I even looked at openfpga.log file but didn't see any warning/error for this one. So, is it not really an issue if mux names are not matching in these two files for specific connections.

MUX name does not have to be the same between operating and physical modes

tangxifan commented 3 years ago

@liaokevin-ql The PR is almost ready to merge. I see no obvious problems in the architecture XML files. You will have to pass pre-PnR functional verifications, during which you may find more bugs in your architecture. When the verifications give you a green light, it is ready to be merged. Just note that you may have to modify your architecture XML (see details at the issue you created)