lnlp / LMIC-node

LMIC-node | One example to rule them all. LMIC-node is an example LoRaWAN application for a node that can be used with The Things Network. It demonstrates how to send uplink messages, how to receive downlink messages, how to implement a downlink command and it provides useful status information. With LMIC-node it is easy to get a working node quickly up and running. LMIC-node supports many popular (LoRa) development boards out of the box. It uses the Arduino framework, the LMIC LoRaWAN library and PlatformIO.
MIT License
223 stars 102 forks source link

Remove setDrTxPowForOtaaExplicit parameter from initLmic() #12

Closed lnlp closed 3 years ago

lnlp commented 3 years ago

Remove the optional setDrTxPowForOtaaExplicit parameter from initLmic() and make this automatic.

Automatic means call LMIC-setDrTxPow() for OTAA automatically if the dataRate or txPower parameter values differ from their default value. For ABP this will have no impact (for ABP the parameters are already used).

lnlp commented 3 years ago

Optional parameter setDrTxPowForOtaaExplicit has been removed from initLmic().

In contrast to making it automatic as suggested above, the option has completely been removed for OTAA because setting initial data rate and transmit power has no effect for OTAA. This is due to how the (MCCI) LMIC library is implemented.