search

lnls-dig / halcs

Hardware Abstraction Layer for Control Systems
GNU General Public License v3.0
1 stars 4 forks source link

New FOFB_processing registers #178

Closed ericonr closed 1 year ago

guilhermerc commented 1 year ago

It looks like there's a missing sign extension when reading back the minimum saturation value from hardware.

[lnls-bpm@lnls-bpm-homologcrate fofb-epics-ioc]$ caput SI-22M1:PS-FCH:FOFBAccSatMin-SP -0.95
Old : SI-22M1:PS-FCH:FOFBAccSatMin-SP -0.95
New : SI-22M1:PS-FCH:FOFBAccSatMin-SP -0.95
[lnls-bpm@lnls-bpm-homologcrate fofb-epics-ioc]$ caget SI-22M1:PS-FCH:FOFBAccSatMinRaw-SP
SI-22M1:PS-FCH:FOFBAccSatMinRaw-SP -15199
[lnls-bpm@lnls-bpm-homologcrate fofb-epics-ioc]$ caget SI-22M1:PS-FCH:FOFBAccSatMinRaw-RB
SI-22M1:PS-FCH:FOFBAccSatMinRaw-RB 50337
[lnls-bpm@lnls-bpm-homologcrate fofb-epics-ioc]$ caget SI-22M1:PS-FCH:FOFBAccSatMin-RB
SI-22M1:PS-FCH:FOFBAccSatMin-RB 3.14606
[lnls-bpm@lnls-bpm-homologcrate fofb-epics-ioc]$
guilhermerc commented 1 year ago

It looks like there's a missing sign extension when reading back the minimum saturation value from hardware.

[lnls-bpm@lnls-bpm-homologcrate fofb-epics-ioc]$ caput SI-22M1:PS-FCH:FOFBAccSatMin-SP -0.95
Old : SI-22M1:PS-FCH:FOFBAccSatMin-SP -0.95
New : SI-22M1:PS-FCH:FOFBAccSatMin-SP -0.95
[lnls-bpm@lnls-bpm-homologcrate fofb-epics-ioc]$ caget SI-22M1:PS-FCH:FOFBAccSatMinRaw-SP
SI-22M1:PS-FCH:FOFBAccSatMinRaw-SP -15199
[lnls-bpm@lnls-bpm-homologcrate fofb-epics-ioc]$ caget SI-22M1:PS-FCH:FOFBAccSatMinRaw-RB
SI-22M1:PS-FCH:FOFBAccSatMinRaw-RB 50337
[lnls-bpm@lnls-bpm-homologcrate fofb-epics-ioc]$ caget SI-22M1:PS-FCH:FOFBAccSatMin-RB
SI-22M1:PS-FCH:FOFBAccSatMin-RB 3.14606
[lnls-bpm@lnls-bpm-homologcrate fofb-epics-ioc]$

Fixed on lnls-dig/fofb-ctrl-gw26c7062 by not shifting these values to the left.