search

lnls-fac / apsuite

Accelerator Physics suite
MIT License
1 stars 2 forks source link

Print BPM name and index when orbit acquisition failed #236

Closed murilobalves closed 1 year ago

anacso17 commented 1 year ago

Maybe we could change FamBPMs to return the name of the problematic BPMs ?

murilobalves commented 1 year ago

Maybe we could change FamBPMs to return name of the problematic BPMs ?

The first thought was including this in the FamBPMs but then I preferred to locate the change in this apsuite class and keep the FamBPMs interface unchanged. It is very simple to get the name of the problematic BPM once you already have a FamBPMs object. What do you think @anacso17 @fernandohds564 ?

anacso17 commented 1 year ago

Maybe we could change FamBPMs to return name of the problematic BPMs ?

The first thought was including this in the FamBPMs but then I preferred to locate the change in this apsuite class and keep the FamBPMs interface unchanged. It is very simple to get the name of the problematic BPM once you already have a FamBPMs object. What do you think @anacso17 @fernandohds564 ?

I see, this would be a big change in FamBPMs interface... We can discuss offline in other opportunity (: