Changes in `injbo_optimize_rcds` made during machine study

lnls-fac / apsuite

Accelerator Physics suite

MIT License

1 stars 2 forks source link

Changes in `injbo_optimize_rcds` made during machine study #273

Closed vellosok75 closed 2 months ago

vellosok75 commented 4 months ago

Changes from 2024-05-27 Machine Study (Optimzation of InjBO)

add klystron2 amplitude & phases and rf amplitude & phase during bottom ramp as optimization knobs;
fix some bugs;

OBS:

@xresende had suggested some changes in the logic for setting knobs and limits. I initially accepted them, but now decided to keep the old format
this PR initially also addressed some issues regarding an undefined variable in RCDS. This issue is now addressed in #275

vellosok75 commented 2 months ago

@vellosok75, I've made a few suggestions in the code.

Thank you, Fernando. I tried to apply the suggestions directly from here, but apparently Github has problems with doing that when there is line deletion (at least it's what the error message said). Anyways, I have commited your suggestions manually.