lnls-sirius / control-system-constants

Sirius Control System static parameters
4 stars 1 forks source link

Update SI SD excdata #210

Closed xresende closed 3 years ago

xresende commented 3 years ago

@xresende, I know the file si-sextupole-s15-sd-fam is not being used any more, but wouldn't be better to update its scaling factor too?

with the average rescaling factor along the whole excitation curve? i thought about deleting this file (and the corresponding sf, qf's...)

fernandohds564 commented 3 years ago

@xresende, I know the file si-sextupole-s15-sd-fam is not being used any more, but wouldn't be better to update its scaling factor too?

with the average rescaling factor along the whole excitation curve? i thought about deleting this file (and the corresponding sf, qf's...)

ok! deleting is better than rescaling by the average. It indeed doesn't make sense, since for low current values the errors are large.

xresende commented 3 years ago

@fernandohds564 , see PR https://github.com/lnls-sirius/control-system-constants/pull/217