search

lnls-sirius / control-system-constants

Sirius Control System static parameters
4 stars 1 forks source link

Update rescaling_factor for SI sexts with avg value #233

Closed xresende closed 1 year ago

xresende commented 3 years ago

@xresende, I think we could leave the old rescaling_factors commented in the files so we can remember their values.

@fernando, all files already had the original correction factors for all families. if you expand file lines you will see the table.

xresende commented 1 year ago

@fernandohds564 , @anacso17 , @murilobalves,

should we drop this set of excdata atualization PRs based on re-measurements or merge them ? we should try to decide on this ando not keep it indefinitely. In my opinion we could merge.

anacso17 commented 1 year ago

@fernandohds564 , @anacso17 , @murilobalves,

should we drop this set of excdata atualization PRs based on re-measurements or merge them ? we should try to decide on this ando not keep it indefinitely. In my opinion we could merge.

@xresende I don't remember the details anymore, but I think this PR was tested in the machine and the result was not as expected, so we decided to keep old rescaling factors and did not returned for optics studies with rescaling factor variation. In this case, I think we should close this PR.

fernandohds564 commented 1 year ago

maybe this one we could close, right?

anacso17 commented 1 year ago

maybe this one we could close, right?

I agree