search

lnls-sirius / control-system-constants

Sirius Control System static parameters
4 stars 1 forks source link

Update PS test values #243

Closed anacso17 closed 2 years ago

anacso17 commented 2 years ago

@anacso17 , maybe we should write down a comment line about the motivation for these non rounded test values, so anyone in the future can easily understand such apparently arbitrary choice

@xresende I had left a comment in 169-170 lines:

# Test values are slightly different for pstypes that share the same beaglebone.
# This choice helps to identify communication and connection issues.

Do you suggest a more detailed comment?

xresende commented 2 years ago

@anacso17 , maybe we should write down a comment line about the motivation for these non rounded test values, so anyone in the future can easily understand such apparently arbitrary choice

@xresende I had left a comment in 169-170 lines:

# Test values are slightly different for pstypes that share the same beaglebone.
# This choice helps to identify communication and connection issues.

Do you suggest a more detailed comment?

no no. I just did not notice these comment lines, even though I searched for them!