search

lnls-sirius / lnls-ansible

Ansible for Sirius
BSD 2-Clause "Simplified" License
3 stars 4 forks source link

Add yamllint and ansible-lint to travis for all roles #45

Open lerwys opened 4 years ago

lerwys commented 4 years ago

Problem: There are many issues with linter, both yaml and ansible. We should add a target to travis to run these linters for all roles.

carneirofc commented 3 years ago

One thing that is not directly related to this but will certainly mitigate problems with bad code being uploaded is the usage of pre-commit. More specifically if we enable ansible-lint within it, as describe here https://ansible-lint.readthedocs.io/en/latest/configuring.html#pre-commit-setup. I have been using pre-commit on most of my projects and it has been really helpful. Every contributor must use pre-commit though (which is not difficult at all).

carneirofc commented 3 years ago

PR https://github.com/lnls-sirius/lnls-ansible/pull/295 will address this problem