lnnrtwttkhn / version-control-book

Source code for the Version Control Book, a guide to Git for scientists
https://lennartwittkuhn.com/version-control-book/
Creative Commons Attribution Share Alike 4.0 International
7 stars 2 forks source link

Split up GitHub chapter, add section on GitHub flow #143

Closed konradpa closed 3 months ago

konradpa commented 5 months ago

This splits up the GitHub chapter in Intro and Advanced. Fixes #102.

Also adds Section about GitHub Flow to GitHub Advanced, this discussed in #141.

lnnrtwttkhn commented 5 months ago

Re GitHub Intro chapter

Thanks @konradpa! Minor changes in https://github.com/lnnrtwttkhn/version-control-book/pull/143/commits/f2dbff60a60fc8e80b0f00d911a4db51aad379f9 and a few comments:

lnnrtwttkhn commented 5 months ago

Re GitHub Advanced

Thanks again @konradpa! A few changes in 7e14647 and comments:

konradpa commented 5 months ago

Thanks for reviewing @lnnrtwttkhn! I added/fixed your suggestions. Except for the fetching/pulling sequence, since I think pulling is used more commonly also more intuitive, so it makes sense to start with it. Im also open for changing it though

konradpa commented 4 months ago

I also customized code boxes like discussed in #168 + #171. And fixed #185 (Instructions for cloning in different folder) @lnnrtwttkhn

lnnrtwttkhn commented 4 months ago

hi @konradpa, I just reviewed the github intro chapter again, very nice! Two thoughts:

will continue reviewing the advanced chapter later.

lnnrtwttkhn commented 3 months ago

I think we've worked long enough on this and we need to merge before the next session.

Thanks your the great work on this PR @konradpa!