search

lnobad / lidgren-network-gen3

Automatically exported from code.google.com/p/lidgren-network-gen3
0 stars 0 forks source link

Small things #136

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
https://code.google.com/p/lidgren-network-gen3/source/browse/trunk/Lidgren.Netwo
rk/NetConnection.Handshake.cs#125
https://code.google.com/p/lidgren-network-gen3/source/browse/trunk/Lidgren.Netwo
rk/NetConnection.Handshake.cs#149
+ 8 for m_peer.m_uniqueIdentifier ?

https://code.google.com/p/lidgren-network-gen3/source/browse/trunk/Lidgren.Netwo
rk/NetConnection.Handshake.cs#200
4 for (float)NetTime.Now ?

Original issue reported on code.google.com by imho.sapiens@gmail.com on 21 Sep 2012 at 5:11

GoogleCodeExporter commented 9 years ago 
Thanks! It did worked before but it's more efficient to preallocate the correct 
amount. Fixed in 313

Original comment by lidg...@gmail.com on 24 Sep 2012 at 7:11

GoogleCodeExporter commented 9 years ago 
Thanks.

PS Replace all "" -> String.Empty ? ;)

Original comment by imho.sapiens@gmail.com on 24 Sep 2012 at 5:53

GoogleCodeExporter commented 9 years ago 
https://code.google.com/p/lidgren-network-gen3/source/browse/trunk/Lidgren.Netwo
rk/NetConnection.Handshake.cs#152
+ m_localHailMessage.LengthBytes

Original comment by imho.sapiens@gmail.com on 24 Sep 2012 at 9:54

GoogleCodeExporter commented 9 years ago 
Hehe fixed in 315

Original comment by lidg...@gmail.com on 25 Sep 2012 at 7:17

GoogleCodeExporter commented 9 years ago 
Maybe add bool NetIncomingMessage.EndOfMessage ? =)

Original comment by x000...@gmail.com on 7 Oct 2012 at 7:00

GoogleCodeExporter commented 9 years ago 
EndOfMessage? The message has an explicit length so no need for an end of 
message marker, if that is what you mean.

Original comment by lidg...@gmail.com on 8 Oct 2012 at 6:39

GoogleCodeExporter commented 9 years ago 
im.Read...
im.Read...

if ( !im.EndOfMessage ) {
  im.Read...
  im.Read...
}

Original comment by imho.sapiens@gmail.com on 8 Oct 2012 at 7:40

GoogleCodeExporter commented 9 years ago 
while(im.Position < im.LengthBits)
   im.Read...

Original comment by lidg...@gmail.com on 8 Oct 2012 at 7:56