search

lnobad / lidgren-network-gen3

Automatically exported from code.google.com/p/lidgren-network-gen3
0 stars 0 forks source link

NetIncommingMessage.Position in bits #40

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
It is good to add PositionInBytes property or perhaps Position returns bytes 
and add PositionInBits.

Original issue reported on code.google.com by NN1436401@gmail.com on 8 Sep 2010 at 7:53

GoogleCodeExporter commented 9 years ago 
PositionInBytes added in rev 117. Having Position in bytes makes more sense 
with regards to the Stream base class override; on the other hand position in 
bytes is not "the truth" and could easily lead to bugs if not understood 
properly.
I may change it later, but for now i'm reluctant to introduce a breaking change.

Original comment by lidg...@gmail.com on 12 Sep 2010 at 8:06

GoogleCodeExporter commented 9 years ago 
I see the problem.

In my case I'm reading everything by byte but in general case Position in bytes 
is a kind of problematic one.
If you see this change causing problems, you can always revert :)

Original comment by NN1436401@gmail.com on 13 Sep 2010 at 7:15