lnp2pBot / bot

Peer-to-peer lightning network telegram bot
MIT License
202 stars 102 forks source link

Remove the prefix lightning: #542

Closed grunch closed 2 weeks ago

grunch commented 2 months ago

Remove the prefix lightning: in case the input from the user have it, some lightning wallets use it when create invoices.

This must be done in each case when a buyer adds an invoice.

FullStackWebDeveloper-HARSH commented 2 months ago

Hi Francisco Calderón

I would like to work on this issue. Could you please assign it to me?

Thank you!

Best regards, Harsh Tiwari

Catrya commented 1 month ago

Hi, @FullStackWebDeveloper-HARSH are you still working on this issue or can it be released for someone else to take? It has been added to: https://github.com/orgs/lnp2pBot/projects/2/ with sats rewards for whoever completes it

danfercf1 commented 1 month ago

Hello, I'm interested to resolve this issue.

Please let me know if there is an initial information that I need to know or if there is an on boarding process.

Kind Regards

Daniel Candia

grunch commented 1 month ago

Hello, I'm interested to resolve this issue.

Please let me know if there is an initial information that I need to know or if there is an on boarding process.

Kind Regards

Daniel Candia

Hi @danfercf1 sure you can take it, this an easy one, it will help you to start getting familiar with lnp2pbot, you just need to find where we receive lightning invoices (spoiler alert, validateInvoice()), if the invoice starts with lightning: you remove that prefix and continue to validate it, if not, keep the regular procedure

danfercf1 commented 1 month ago

Alright, thank you for the hint, I will start the task today

danfercf1 commented 3 weeks ago

Hi @grunch , please, could you explain where is used this method validateInvoice()? I found it but it's not called, I found that the validation is implemented on this method validateInvoice()

grunch commented 2 weeks ago

Great job @danfercf1 thank you, please send us a LN invoice with amount 50000 sats as a comment here

danfercf1 commented 2 weeks ago

You're welcome, thank you too This is my invoice:

lnbc500u1pnvl8z8pp5k86f6vq72uef3wa2knzysh3739z2ajkg6q8lh6ry0mv27qp4pfescqpjsp59st2s99h3hzd8wjzy6z703ktxpvzgzf340khs4k0uxdzhc53vcjs9q7sqqqqqqqqqqqqqqqqqqqsqqqqqysgqdqqmqz9gxqyjw5qrzjqwryaup9lh50kkranzgcdnn2fgvx390wgj5jd07rwr3vxeje0glcllesp7j2jvfdcsqqqqlgqqqqqeqqjqqfzqulwk63gv4yhwz4wtxq09056xmmg5r5etyqnynlsg70kkunzn9a30s30m5ggmhszz82u5l05r03mgdzsd0sexd0ta7a5z28qw95cptx24a2

grunch commented 2 weeks ago

lnbc500u1pnvl8z8pp5k86f6vq72uef3wa2knzysh3739z2ajkg6q8lh6ry0mv27qp4pfescqpjsp59st2s99h3hzd8wjzy6z703ktxpvzgzf340khs4k0uxdzhc53vcjs9q7sqqqqqqqqqqqqqqqqqqqsqqqqqysgqdqqmqz9gxqyjw5qrzjqwryaup9lh50kkranzgcdnn2fgvx390wgj5jd07rwr3vxeje0glcllesp7j2jvfdcsqqqqlgqqqqqeqqjqqfzqulwk63gv4yhwz4wtxq09056xmmg5r5etyqnynlsg70kkunzn9a30s30m5ggmhszz82u5l05r03mgdzsd0sexd0ta7a5z28qw95cptx24a2

Paid! preimage cc1aade0eba54034553d46b2253b57b84acb0783a4af1ef2843666e9c2795208