search

lnp2pBot / bot

Peer-to-peer lightning network telegram bot
MIT License
212 stars 106 forks source link

Remove the lightning prefix from the lnInvoice #572

Closed danfercf1 closed 3 months ago

danfercf1 commented 3 months ago

Removing the lightning prefix from the commands file and the validation

Fixes #542

danfercf1 commented 3 months ago

Yes, you are right, I comitted the missed file

danfercf1 commented 3 months ago

I already moved it to the folder util and changed its name to camelcase format names

Catrya commented 3 months ago

Hi @danfercf1 let's wait for @grunch to review and decides

grunch commented 3 months ago

Hi @danfercf1 let's wait for @grunch to review and decides

I think after move the new file to .ts we can merge

danfercf1 commented 3 months ago

I updated the new file to Typescript

grunch commented 3 months ago

Hi @danfercf1 thank you for your contribution, before we merge it we need to have the conflict solved, validation.js file has just been moved to validation.ts

danfercf1 commented 3 months ago

Hi @danfercf1 thank you for your contribution, before we merge it we need to have the conflict solved, validation.js file has just been moved to validation.ts

I will take a look

danfercf1 commented 3 months ago

I updated the file validation.ts

grunch commented 3 months ago

Hey @danfercf1 because we have a buggy PR merged (#557) we need to revert this one, your code is ok I will include in a new version, thanks again