search

lnu-norge / lokaler.lnu.no

A website for finding spaces to be in for Norwegian volunteer organizations
http://lokaler.lnu.no/
GNU Affero General Public License v3.0
10 stars 2 forks source link

Adding release db:migrate to Procfile #182

Closed Laaknor closed 2 years ago

Laaknor commented 2 years ago

This is how I do DB:Migrate in another project I've got

mathias234 commented 2 years ago

Seems to kill foreman after the release part is done image If we want to use procfile for this we probably need to use a seperate procfile for dev e.g foreman s -f Procfile.dev we have that file but I don't believe anyone uses it

Laaknor commented 2 years ago

That is not related to the changes I've done (release is supposed to exit after it's run). Foreman has not worked for me for a long time. But according to heroku documentation, this is the way to add db:migrate before new production code is put in production https://devcenter.heroku.com/articles/release-phase

mathias234 commented 2 years ago

....

Because release exits, it seems that foreman ends up sending SIGTERM/SIGKILL to the other long-running processes, which ends up killing webpack and guard, which should be running during development. Not sure why foreman isn't working for you, but it is working in main without this change.

Laaknor commented 2 years ago

Removed release from my Procfile, and now suddently it works (didn't on saturday when I tested it). Closeing this, as we must find another way of doing it.

DanielJackson-Oslo commented 2 years ago

Could we have a seperate procfile for heroku/prod?