lnug / website

The London Node User Group Website
MIT License
14 stars 19 forks source link

Issues with npm run build #105

Closed rdquintas closed 8 years ago

rdquintas commented 8 years ago

Hi guys, I'm struggling to build this app on my machine, and getting some build errors. Can anyone help me, please.

This is what I have installed node v5.5.0 npm v3.6.0

Not sure if I'm doing anything wrong. See attached npm-debug.log npm-debug.log.txt

Cheers

rdquintas commented 8 years ago

Also have the same issue with npm start

simonmcmanus commented 8 years ago

what error do you get on an npm start?

simonmcmanus commented 8 years ago

I can't see anything obvious wrong.

It's worth deleting node_modules and doing a clean npm install.

rdquintas commented 8 years ago

Thanks @simonmcmanus I have solved the issue.

Changed package.json

from this

"scripts": {
    "test": "standard && mocha --recursive test",
    "update": "./bin/update-json.js",
    "build-markup": "./bin/build-markup.js",
    "start": "./bin/server.js",
    "build": "npm run update && npm run build-markup"
  },

to this

"scripts": {
    "test": "standard && mocha --recursive test",
    "update": "node ./bin/update-json.js",
    "build-markup": "node ./bin/build-markup.js",
    "start": "node ./bin/server.js",
    "build": "npm run update && npm run build-markup"
  },

As you can see above, all that I did was to pre-pend the command node to each script instruction. Have no idea why it wasn't working without the "node" command. Maybe because I'm running this on a windows machine.

Works like a charm now.

Cheers.

iancrowther commented 8 years ago

What os?

rdquintas commented 8 years ago

Windows 10

/Ricardo www.ricardoquintas.com

On 31 Jan 2016, at 20:07, Ian Crowther notifications@github.com wrote:

What os?

— Reply to this email directly or view it on GitHub.

lnugbot commented 8 years ago

And how did you install? Installer, nvm or something similar? Helps us build better apps in the future On Sun, 31 Jan 2016 at 20:14, Ricardo Quintas notifications@github.com wrote:

Windows 10

/Ricardo www.ricardoquintas.com

On 31 Jan 2016, at 20:07, Ian Crowther notifications@github.com wrote:

What os?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/lnug/lnug.github.io/issues/105#issuecomment-177599842 .

simonmcmanus commented 8 years ago

Windows doesn't understand the

!/usr/bin/env node

at the top of the scripts its running.

If you want to make a pull request we will get that merged in right away.

Thanks Ricardo

On 31 January 2016 at 18:56, Ricardo Quintas notifications@github.com wrote:

Thanks @simonmcmanus https://github.com/simonmcmanus I have solved the issue.

Changed package.json

from this

"scripts": { "test": "standard && mocha --recursive test", "update": "./bin/update-json.js", "build-markup": "./bin/build-markup.js", "start": "./bin/server.js", "build": "npm run update && npm run build-markup" },

to this

"scripts": { "test": "standard && mocha --recursive test", "update": "node ./bin/update-json.js", "build-markup": "node ./bin/build-markup.js", "start": "node ./bin/server.js", "build": "npm run update && npm run build-markup" },

As you can see above, all that I did was to pre-pend the command node to each script insctrution. Have no idea why it wasn't working without the "node" command. Maybe because I'm running this on a windows machine.

Works like a charm now.

Cheers.

— Reply to this email directly or view it on GitHub https://github.com/lnug/lnug.github.io/issues/105#issuecomment-177584142 .

Simon McManus

DotJS Ltd - Node Consultancy

rdquintas commented 8 years ago

@lnugbot I have installed using installer

@simonmcmanus I see. So I can't use the shebang line I guess, when using Windows. BTW, saw this interesting discussion on the subject here http://stackoverflow.com/questions/33509816/what-exactly-does-usr-bin-env-node-do-at-the-beginning-of-node-files Another alternative for me (without changing the package.json) would be to run the script directly without using npm, but instead for example

node bin/server

what do you suggest @simonmcmanus ?

lnugbot commented 8 years ago

Adding the node to the start of the commands like in your example should be fine. It will just mean windows knows how to handle the command.

Let me know if you have any questions

Sent from my iPhone

On 31 Jan 2016, at 20:56, Ricardo Quintas notifications@github.com wrote:

@lnugbot https://github.com/lnugbot I have installed using installer

@simonmcmanus https://github.com/simonmcmanus I see. So I can't use the shebang line I guess, when using Windows. BTW, saw this interesting discussion on the subject here http://stackoverflow.com/questions/33509816/what-exactly-does-usr-bin-env-node-do-at-the-beginning-of-node-files Another alternative for me (without changing the package.json) would be to run the script directly without using npm, but instead for example

node bin/server

what do you suggest @simonmcmanus https://github.com/simonmcmanus ?

— Reply to this email directly or view it on GitHub https://github.com/lnug/lnug.github.io/issues/105#issuecomment-177608506.

rdquintas commented 8 years ago

This issue can be closed. All working fine.