lnug / website

The London Node User Group Website
MIT License
14 stars 19 forks source link

build failing #137

Closed admataz closed 7 years ago

admataz commented 7 years ago

Hi @simonmcmanus

I'm getting an error when running npm run build to update the speakers - it looks like it's failing on the speclate --build script.

This worked last time I ran it, but we had all 3 speaker slots full - is it something to do with there only being one speaker confirmed so far?

I saw you did some updates recently - so I trashed my npm_modules and reinstalled - no help.

Any guidance helpful...

Thanks.

Error excerpt below:

> lnug.github.io@1.0.0 html /Users/adam/Documents/community/LNUG/website
> speclate --build

Speclate v12.1.0 cli v5.0.1

Validating spec..
  ok

Generating markup..
/Users/adam/Documents/community/LNUG/website/node_modules/sizlate/lib/update-node.js:21
            if (data.length) {
                    ^

TypeError: Cannot read property 'length' of null
    at updateNode (/Users/adam/Documents/community/LNUG/website/node_modules/sizlate/lib/update-node.js:21:21)
    at /Users/adam/Documents/community/LNUG/website/node_modules/sizlate/lib/do-render.js:18:13
    at Array.forEach (native)
    at Object.module.exports [as render] (/Users/adam/Documents/community/LNUG/website/node_modules/sizlate/lib/do-render.js:17:47)
    at /Users/adam/Documents/community/LNUG/website/node_modules/speclate/lib/page/load-components.js:23:30
    at Array.forEach (native)
    at renderComponent (/Users/adam/Documents/community/LNUG/website/node_modules/speclate/lib/page/load-components.js:20:20)
    at /Users/adam/Documents/community/LNUG/website/node_modules/speclate/lib/page/load-components.js:69:46
    at tryToString (fs.js:426:3)
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:413:12)
simonmcmanus commented 7 years ago

Hi Adam will take a look on my lunch break

Thanks for letting me know

Sent from my iPhone

On 27 Mar 2017, at 9:43 am, Adam Davis notifications@github.com wrote:

Assigned #137 to @simonmcmanus.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

simonmcmanus commented 7 years ago

The build is fixed and I have pushed out an update to the site.

The issue was due to the github account not having a name field. It now uses the handle when name is not available. I will also get a fix into speclate soon

admataz commented 7 years ago

thanks @simonmcmanus ⭐️

simonmcmanus commented 7 years ago

Its actually Sizlate which needs the fix, The issue is here:

https://github.com/simonmcmanus/sizlate/issues/36