lnx-search / datacake

Tooling for creating your own distributed systems.
MIT License
390 stars 22 forks source link

feature: made `Storage` to be a super trait #33

Closed druzn3k closed 1 year ago

druzn3k commented 1 year ago

Storage now implements explicitly also the traits Send + Sync + 'static, as they are needed everywhere Storage is needed. Thanks to @ChillFish8 for the guidance.

druzn3k commented 1 year ago

Don't mind the name of the super trait, it's meant to be temporary till discussed with you.

ChillFish8 commented 1 year ago

I see what you mean, although I have a different set of false positives.

I think i've fixed it by simplifying the trait to just require the super traits on the storage trait itself. We can do this since you need to meet these requirements anyway.

druzn3k commented 1 year ago

Thank you, I will take a look at your commit right away.

druzn3k commented 1 year ago

Ok @ChillFish8, I've seen the modification. It was the first approach that I wanted to do but discarded because I thought that was done like this for a reason and I didn't want to break existing codes. I will edit the PR title and text to match the current implementation.

ChillFish8 commented 1 year ago

It was the first approach that I wanted to do but discarded because I thought that was done like this for a reason and I didn't want to break existing codes.

Ah no, it was just left over from incrementally building it and the required constraints. Let me know when this is good to go :)

druzn3k commented 1 year ago

For me it's good to go, if the title and descriptions fits the required standard.