search

lo-cafe / winston

A beautiful and native Reddit client for iOS
https://winston.cafe/
GNU General Public License v3.0
944 stars 65 forks source link

[Bug] Markdown Tables Don’t Respect the Theme #431

Open winnybot opened 8 months ago

winnybot commented 8 months ago

Describe the bug https://i.imgur.com/X74C7Pz.jpg

To Reproduce Steps to reproduce the behavior:

  1. Find a markdown element
  2. Observe the discolored UI elements

Expected behavior A workaround would be to set the markdown element color values to #FFFFFF with transparency set below 50%, so that the markdown elements are always blending with UI colors in respect to the users enabled theme.

Device (please complete the following information): iPhone 13 Pro iOS 17.3

Posted by psyclaire

ojsef39 commented 7 months ago

isn't that just a code block? @Psyclaire

Psyclaire commented 7 months ago

isn't that just a code block? @Psyclaire

Yes, the code block is what I meant. Apologies for the confusion. @ojsef39

ojsef39 commented 7 months ago

Yes, the code block is what I meant. Apologies for the confusion. @ojsef39

No thank you for clarifying ;)

So, to understand you completely, you don't want code blocks to have a background or can i close this then? :)

Psyclaire commented 7 months ago

Yes, the code block is what I meant. Apologies for the confusion. @ojsef39

No thank you for clarifying ;)

So, to understand you completely, you don't want code blocks to have a background or can i close this then? :)

I would like the code blocks to have backgrounds (so they are easily distinguishable as code blocks), but I was hoping for the code blocks background to respect theme colors. This is more of an aesthetic request, as the current iteration of code blocks fucntions perfectly fine.

If the code block background was set to #FFFFFF with a transparency of 50%, this would allow the code block to respect the theme via the themes foreground color value showing through the code blocks transparency.

Feel free to ping me on the discord if there’s anything else I can clarify :) @ojsef39