I haven't thought this out to much yet, but I think that we might be able to provide a nicer API for the sampling efficiency. My suggestion is to have a root class that is a composition of it's children. The root class has a single method get_efficiency or something like that that will serve as the signature for returning an efficiency or array of efficiencies. This class might also have some attributes such as diameter and efficiency. Then, the children would implement the details and decorate the parent with methods and attributes specific to that implementation. The get_efficiency in the parent object would then be a product of the overriden methods in the children. This sounds confusing so I will try to show what I mean. All of Hagen's calculations in the existing module would remain the same.
hagne
commented
8 years ago
I haven't thought this out to much yet, but I think that we might be able to provide a nicer API for the sampling efficiency. My suggestion is to have a root class that is a composition of it's children. The root class has a single method
get_efficiencyor something like that that will serve as the signature for returning an efficiency or array of efficiencies. This class might also have some attributes such as diameter and efficiency. Then, the children would implement the details and decorate the parent with methods and attributes specific to that implementation. The get_efficiency in the parent object would then be a product of the overriden methods in the children. This sounds confusing so I will try to show what I mean. All of Hagen's calculations in the existing module would remain the same.