lo-th / Oimo.js

Lightweight 3d physics engine for javascript
http://lo-th.github.io/Oimo.js
MIT License
3.05k stars 301 forks source link

The function to set a Quat from Mat33 doesn't work. #69

Open d3x0r opened 6 years ago

d3x0r commented 6 years ago

This function is not referenced by any other code, so it's not very important to fix... but... by line 284 output[3] is never set. Output[i-j] is set... but I, J and K are numbers between 0 and 2. So quat.z will be set to undefined.

https://github.com/lo-th/Oimo.js/blob/gh-pages/src/math/Quat.js#L253