search

lo-th / Oimo.js

Lightweight 3d physics engine for javascript
http://lo-th.github.io/Oimo.js
MIT License
3.05k stars 301 forks source link

Forced isKinematic = true when setPosition/setQuaternion #80

Open wmcmurray opened 5 years ago

wmcmurray commented 5 years ago

Hey, I just spent a long time trying to understand why my dynamic meshes where not moving at all, until I found this :

https://github.com/lo-th/Oimo.js/blob/6c3e7e7552cdfcb7a40a0107339841ea9fdc0138/src/core/RigidBody.js#L436-L446

Those two methods have this line of code at the end :

if( !this.isKinematic ) this.isKinematic = true;

which makes no sense to me, how changing the position of a dynamic object automatically makes it of kinematic type ?? :thinking:

This has been commited 2 years ago, it's surprising that it has not been spotted before, so maybe I misunderstood something ?

Thanks :slightly_smiling_face: !