search

lo1tuma / eslint-plugin-mocha

ESLint rules for mocha
MIT License
279 stars 61 forks source link

Support Node 18 + switch from ramda to rambda #326

Closed taymoork2 closed 2 years ago

taymoork2 commented 2 years ago

Thanks to @jrandolf for the original PR #325 this is based off

image
taymoork2 commented 2 years ago

@lo1tuma, not be a bother, but can I get a review or update?

lo1tuma commented 2 years ago

Hi @taymoork2, sorry for the late reply, but I was on vacation the last two weeks. I hope to find some time this week to take a closer look at this PR and rambda itself.

My first impression is it looks quite good and well maintained. Although it seems like they don’t support importing functions individually. Can you confirm this? Since we don’t use any bundle we won’t profit from thee-shaking.

taymoork2 commented 2 years ago

@lo1tuma it's all good

My first impression is it looks quite good and well maintained. Although it seems like they don’t support importing functions individually. Can you confirm this? Since we don’t use any bundle we won’t profit from thee-shaking.

From what i can see, Rambda, does not support require('rambda/'). The screenshot above show's the runtime with individually imported functions/the PR, I tested using yalp (aka npm link)

lo1tuma commented 2 years ago

@taymoork2 I’ve also checked the result of the startup benchmark and it seems like rambda improves the performance by round about 50%, both regarding runtime duration as well as memory usage.

I’ve only found one small issue, once that is fixed I’m happy to merge this PR.