search

lo1tuma / eslint-plugin-mocha

ESLint rules for mocha
MIT License
279 stars 61 forks source link

Breaking change accidentally release in 10.4.0 #351

Closed newhouse closed 6 months ago

newhouse commented 6 months ago

Hi there - love this package and thanks for all the hard work!

There is a problem with your latest release of 10.4.0 however:

This is an accidentally breaking change for projects (like one of ours) that are running on Node 16, with a dependency of something like "eslint-plugin-mocha": "^10.2.0"

I'm not sure what you're using from globals, but it seems like 13 is compatible with Node >=8, so you can probably just change your dependency to some version of 13 and be ok, or perhaps with minor changes.

Would you consider fixing things in a patch of some sort in the 10.x semver realm?

lo1tuma commented 6 months ago

Thanks for reporting. I’ve downgraded globals to 13.24.0 and made a patch release of eslint-plugin-mocha, so v10.4.1 should hopefully fix this issue. Please let me know it it works for you.

rhysd commented 6 months ago

Ah, thank you for the follow up. I didn't notice the minimum Node.js version. (Node.js v16 is no longer supported and everyone should migrate to v18 or later, though.)

BTW, this package specifies engines.node>=20.0.0 in package.json. What are the supported Node.js versions?

https://github.com/lo1tuma/eslint-plugin-mocha/blob/a936f2ace2191d0b26b70a34e19711e6a4252659/package.json#L6

lo1tuma commented 6 months ago

BTW, this package specifies engines.node>=20.0.0 in package.json. What are the supported Node.js versions?

The main branch contains unreleased breaking changes which I planning to release as part of eslint-plugin-mocha v11. But I’ve cherry-picked the changes from #349 to make another 10.x release.

newhouse commented 6 months ago

Thanks @lo1tuma and @rhysd !

Things look good now with ^10.14.1.

I haven't looked closely over the timing of various changes, etc, but was surprised it was not caught in the CI tests given that you had a matrix of all supported engines set up: https://github.com/lo1tuma/eslint-plugin-mocha/commit/767d90053df13cdbbd23f3d14c52d10148986871

Anyways, thanks again!!! You can close this, IMO.