search

loadout-ink / splat2-calc

Gear planning tool for Splatoon 2.
MIT License
111 stars 30 forks source link

Support for zh_HK (Cantonese/Chinese) #8

Closed sam0737 closed 6 years ago

sam0737 commented 7 years ago

Adding support for zh_HK (Cantonese/Chinese) user.

Since there is no official Chinese version of Splatoon, we in Hong Kong play with Japanese or US version instead. Most Hong Konger doesn't know Japanese but we are left with no choice, Japanese is still a popular pick since the splatfest will be at a better time due to timezone issue.

My translation has the description in Chinese yet the gears name are in Japanese. I modified the code a bit to allow gears to be fallback to ja_JP.

For US, I bet those players does understand English so I am not doing another set of translation.

P.S. commit 6044833 is a bugfix for all language though P.P.S: Cantonese is slightly different from Mandarin used in China or Chinese in Taiwan. They are pronounced very differently, with slightly different grammar and language use while the character is mostly the same. That's the mother tongue for Hong Konger. Those understand written Cantonese usually understand written Chinese, reverse is NOT usually the case.

DeviPotato commented 7 years ago

Thank you very much for the contribution and the extra information. It's very helpful to know all of these things. I'll review this and try to implement it quickly.

DeviPotato commented 6 years ago

I'm very sorry for the delay on this pull request. I took an unplanned hiatus from this project for personal reasons and just started work on it again a few days ago. I am working through all of the things I am behind on now.

I will be testing this and the Italian localization tomorrow, and will merge this if everything looks OK.

Once again, thank you for your contribution. I will try to implement your translation in the next day or two.

Thank you for being patient!

DeviPotato commented 6 years ago

Just pulled this in. This will go live with the next update. :)

Thank you for your contribution!