search

loads / loads-web

Web dashboard for Loads
Apache License 2.0
5 stars 3 forks source link

Add HTML5 notifications to the gist validation button #74

Closed darkwing closed 9 years ago

darkwing commented 9 years ago

Instead of dumping in HTML element messages and balancing all that, HTML5 notifications ftw.

pdehaan commented 9 years ago

BOOM! :boom: 

> loads-web@1.0.0 lint /home/travis/build/loads/loads-web
> eslint .

client/static/assets/scripts/controllers.js
  23:12  error    Do not use 'new' for side effects  no-new
  25:14  error    Missing semicolon                  semi
  30:8   warning  Unexpected alert                   no-alert

✖ 3 problems (2 errors, 1 warning)

You can ignore the alert() warning, we're missing a semi-colon, and not sure how I feel about that no-new error. We can probably just resolve that by editing the .eslintrc file and adding a no-new: 1 rule to it (which turns it into a warning, but doesn't fail the build).

pdehaan commented 9 years ago

Preemptive :+1: from me. Feel free to resolve the ESLint errors however you see fit and then self-merge when you're ready.

darkwing commented 9 years ago

Updated, we'll see what Travis says...

pdehaan commented 9 years ago

Travis is green. Merge is on.