search

loadsmart / danger-android_lint

A Danger plugin for Android Lint
https://developer.android.com/studio/write/lint.html
MIT License
55 stars 24 forks source link

Fix the count number for issues #5

Closed jettbow closed 7 years ago

jettbow commented 7 years ago

Fix the issue that the count of issues is not correct for non-inline mode.

barbosa commented 7 years ago

Hey @jettbow, Thanks for the PR!

Do you have a link or a screenshot of the error? So I can understand what exactly is going on?

jettbow commented 7 years ago

@barbosa Sorry for the unclear description. Let me elaborate more. Our project use this library and we love it. But we found if we use standard mode instead of inline mode, the danger still shows the total count of warning and error for whole project even there is no warning and error in the PR changes. e.g. The comments with no error and warning looks like :

Error (72)

File Line Reason

Warning (1751)

File Line Reason

Both tables are empty.

barbosa commented 7 years ago

Thank you, @jettbow 🎉

barbosa commented 6 years ago

@jettbow We've just published a new version of the gem with your changes (0.0.5). Sorry for taking so long.