search

loadsmart / danger-android_lint

A Danger plugin for Android Lint
https://developer.android.com/studio/write/lint.html
MIT License
55 stars 24 forks source link

Add option for skipping gradle task #6

Closed litmon closed 6 years ago

litmon commented 6 years ago

I want to skip gradle lint task, so add option for skipping gradle task.

barbosa commented 6 years ago

Hi @litmon! Thank you for the PR.

Would you mind explaining me a little bit more what this PR is trying to achieve? In which scenario you'd want to skip the task? Since its main purpose is to run the lint against your code base, why would you want to skip that? I'm not sure if I'm following here, sorry :(

litmon commented 6 years ago

I want to use only parser for lint-result.xml, because lint-result.xml already exists in my environments(already runs lint task before execute danger).

barbosa commented 6 years ago

Oh I see. You're right. That makes sense. Thanks for explaining and for the contribution!

litmon commented 6 years ago

thanks for merging!

barbosa commented 6 years ago

Hi @litmon! Just to let you know we've just published a new version of the gem with your changes (0.0.5).

Thank you once again!