Proposal: change plugin name to danger-flake8

loadsmart / danger-pep8

A Danger plugin for Python's PEP 8

https://www.python.org/dev/peps/pep-0008/

MIT License

9 stars 3 forks source link

Proposal: change plugin name to danger-flake8 #3

Open barbosa opened 7 years ago

barbosa commented 7 years ago

Aborted.

danpalmer commented 7 years ago

Hi, any reason this was aborted? We use flake8 for our Python linting, but specifically do not adhere to pep8, so it wouldn't be particularly clear having reports from "DangerPep8".

barbosa commented 7 years ago

Hey @danpalmer

We thought at that time that maybe this plugin would be only something to guarantee the code adheres to pep8, without taking its internal implementation into consideration.

But it evolved since then and maybe now it doesn't make sense anymore. Renaming it to danger-flake8 might be the best thing to do now.

We'd probably have to create a new plugin based on this, and mark this one as deprecated, keeping both gems available though.

@rcmachado thoughts?

rcmachado commented 7 years ago

I agree with @barbosa, specially if we consider the #7.