loadsmart / rn-salesforce-chat

React Native wrapper for Salesforce SDK chat
MIT License
7 stars 10 forks source link

sets defaultToMinimized to false for iOS #38

Closed matthewparavati closed 1 year ago

matthewparavati commented 1 year ago

Types of changes

Include the types of changes

Reason for the changes

Matches the behavior of android to launch the chat in maximized state

Description of the proposed changes

Sets defaultToMinimized to false on iOS so the chat launches in the maximized state when openChat is called

I'd understand if the preference would be to have this as an optional property of the ChatConfig interface but since android was hardcoded as false and for our use case, we'd prefer the chat to launch similarly on iOS, I've added it directly to RNSalesforceChat.m

Screenshots

N/A

aotaduy commented 1 year ago

Hello it wil vbe very useful if you publish this changes. Thanks for the lib !

matthewparavati commented 1 year ago

@lenoirzamboni @gutofoletto thanks for the approvals. Are you able to merge this or does anyone else need to be tagged to get this merged and hopefully a new release? 🤞

lenoirzamboni commented 1 year ago

@lenoirzamboni @gutofoletto thanks for the approvals. Are you able to merge this or does anyone else need to be tagged to get this merged and hopefully a new release? 🤞

@matthewparavati sorry for the delay. Version 3.4.1 is released.