search

loambuild / loam

build, deploy, and maintain ambitious smart contracts. monorepo for Loam SDK, CLI, and shared tools.
https://loam.build
2 stars 7 forks source link

fix dev command #152

Open BlaineHeffron opened 4 weeks ago

BlaineHeffron commented 4 weeks ago

Fixes https://github.com/loambuild/loam/issues/148

There were three issues: the build command was using a Mutex guard unnecessarily since there was already a mutex state to lock when rebuilds occur. This lock was preventing rebuilds and causing the bug.

Second is it was watching for the file environments.toml rather than watching the directory and for the env file within it. This was causing a problem where if there wasn't an environments.toml file it would throw an error.

Third issue was the test function that checked for lines from the stderr stream wasn't actually failing when it should since it wasn't infinitely looping within the timeout method.

chadoh commented 3 weeks ago

Looks like legitimate test failures, too

BlaineHeffron commented 3 weeks ago

Looks like legitimate test failures, too

I'm not sure what the example core stuff is