changing the manual path vars to $path

loathers / TourGuide

Relay script for KoLmafia, for the web game Kingdom of Loathing. Gives advice on how to play.

The Unlicense

14 stars 17 forks source link

changing the manual path vars to $path #110

Closed docrostov closed 1 year ago

docrostov commented 1 year ago

all of these can just be $path calls lol

JamesDowney commented 1 year ago

https://github.com/loathers/TourGuide/blob/b493ddc4ca3f155ab03384e2240ca378866dc346/Source/relay/TourGuide/Support/Statics.ash#L4-L58

docrostov commented 1 year ago

closing this because honestly after doing all the LoL support i have now realized that these statics actually are mildly helpful because writing $path[Legacy of Loathing] is much more prone to bugs than letting VSCode autocomplete PATH_LEGACY_OF_LOATHING for you. i am pretty sure at least 5 PRs in the LoL PR were me mispelling Legacy of Loathing in the $path call because i write tourguide code when i am tired.