loathers / TourGuide

Relay script for KoLmafia, for the web game Kingdom of Loathing. Gives advice on how to play.
The Unlicense
14 stars 17 forks source link

abstract TES tile of familiar drops into its own combination tag tile #179

Open docrostov opened 1 year ago

docrostov commented 1 year ago

https://github.com/loathers/TourGuide/blob/09e0658b2b99da7549daad031780a74dbd49cfa7/Source/relay/TourGuide/Items%20of%20the%20Month/2010/Crown%20of%20Thrones.ash#L250

this has been in tourguide for a while and it is a very useful little tile component -- it shows the number of drops you've gotten from every familiar with limited drops and how close you are to exhausting the daily limit. instead of formatting this as is, what i want to do is move this into Familiars.ash (or an all-new FamiliarDrops.ash) and create a combination tag for the different familiar drops where each drop only appears if the familiar is usable, where they are ordered by in-run value in order to create a slightly nicer version of this (and one where important familiar drops in standard can be aggregated if those ever come back).

we can also, as an added bonus, add % chance of getting X for some of the familiars that have technically infinite drops where it grays it if it's so low you probably don't want to use the familiar anymore. to me, this is not as important as the pull list updates (which i want to have ready to go by the end of the month) but this actually is reasonably high in priority value because the TES tile is a pretty good baseline and this is a relatively easy transition that should both save space and make these visible in hardcore unrestricted, which i think we want.