search

loathers / TourGuide

Relay script for KoLmafia, for the web game Kingdom of Loathing. Gives advice on how to play.
The Unlicense
14 stars 17 forks source link

monstrous boiler & screambat are non-wishable #180

Closed docrostov closed 7 months ago

docrostov commented 10 months ago

these appear as valid wish suggestions within tourguide and tourguide is wrong. however, well. https://github.com/loathers/TourGuide/blob/09e0658b2b99da7549daad031780a74dbd49cfa7/Source/relay/TourGuide/Items%20of%20the%20Month/2017/GenieBottle.ash#L29 we already tell tourguide those aren't wishable! vinny reported that tourguide was still recommending those as wish targets, which means either SFaxGeneratePotentialWishes is broken or something else is broken. i don't get why ninja assassin would properly remove itself from the target list but neither of those would. ugh. what an annoying lil bug.

danielwhite commented 10 months ago

A bit sheepish that I didn't catch this in #168. Was curious why it didn't work happened and have a draft in #181 that can address this.

why ninja assassin would properly remove itself from the target list but neither of those would

Turns out each addition was manually checking the blocked_monster array, so it was pretty easy to miss any new additions.

docrostov commented 7 months ago

fixed in #181 a while back lol