search

loathers / TourGuide

Relay script for KoLmafia, for the web game Kingdom of Loathing. Gives advice on how to play.
The Unlicense
14 stars 17 forks source link

Exclude any blocked monster when generating potential faxes #181

Closed danielwhite closed 9 months ago

danielwhite commented 10 months ago

This intends to teach SFaxGeneratePotentialFaxes to generate faxes by $monster so that each addition can be evaluated against the blocked_monster argument. The block_monster argument is needed for things like Genie wishes which only support a subset of wishes. #168 expected this to filter out $monster[monstrous boiler], but #180 has revealed this it was only check on on a case-by-case basis and is quite easy to miss.

In doing this, I found it convenient to provide some structure for each potential fax, but it doesn't handle some of the more elaborate variations (e.g. combined white lion / whitesnake enty).

danielwhite commented 10 months ago

Thanks for the feedback. I'll address the comments and resolve the conflicts against main in the next couple days.

danielwhite commented 9 months ago

Resolved the merge conflict and with a little goofing, I've sanity checked all the different recommendations, so largely think this ends up showing up sensibly for both faxes and wishes now.

I think this is good to go.

Hope you don't mind, I dropped a couple of other dead recommendations on the way through.