search

loathers / autoscend

An ascension script for KoLMafia
Other
45 stars 66 forks source link

Incompatible Adv Gear Pulled in Bedtime #1012

Open Alium58 opened 2 years ago

Alium58 commented 2 years ago

Context

Expected/Desired Behavior

Bedtime pulls gear that is good for RO adventures. Expect the pulled gear to all be equipable at the same time

Current Behavior

Pulled and tried to equip: Chrome Sword (2 handed weapon) Mer-kin stopwatch (off hand) Time Halo (acc that only gives adventures if no weapon is equiped)

Maximizer only equiped the stopwatch of these 3. Other adventure gear was equipped properly in other slots.

Alium58 commented 2 years ago 
Maximizer: -tie,adv
> [DEBUG] Bedtime pulls: maximizer is not equipping [time halo] into [acc1] for some reason. Skipping this slot
> [INFO] Pulling [Hairpiece On Fire] which improves desireability score by 4.0

mall.php?category=allitems&consumable_byme=0&weaponattribute=3&wearable_byme=0&nolimits=0&max_price=0&sortresultsby=price&justitems=0&x_cheapest=0&pudnuggler=%22Hairpiece+On+Fire%22

buy 1 Hairpiece On Fire for 7269 each from shop #3061473 on 20220112
> [INFO] Trying to pull 1 of Hairpiece On Fire

pull: 1 Hairpiece On Fire
Preference auto_pulls changed from (1:perfect cosmopolitan:83), (1:pumpkin pie:102), (1:Medical Pastaco:113), (4:perfect cosmopolitan:249), (4:Boris's key lime pie:268), (4:milk of magnesium:268), (4:spaghetti con calaveras:288), (4:pumpkin pie:314), (4:grimstone mask:320), (4:breakfast miracle:329), (5:perfect cosmopolitan:348), (5:perfect negroni:400), (5:perfect dark and stormy:418), (5:ninja carabiner:431), (5:ninja crampons:431), (5:ninja rope:431), (5:perfect mimosa:436), (5:ice wine:454), (5:fleetwood mac 'n' cheese:466), (5:spectral pickle:507), (5:pumpkin pie:528), (5:breakfast miracle:544), (5:hacked gibson:564), (5:antique machete:564), (5:wet stew:564), (5:blackberry galoshes:564), (5:drum machine:564), (5:killing jar:564), (5:time halo:564), (7:titanium assault umbrella:625), (7:amulet of extreme plot significance:625), (8:perfect cosmopolitan:700), (8:perfect negroni:784), (8:fleetwood mac 'n' cheese:811), (8:book of matches:833), (8:spectral pickle:853), (8:Fettris:874), (8:hacked gibson:908) to (1:perfect cosmopolitan:83), (1:pumpkin pie:102), (1:Medical Pastaco:113), (4:perfect cosmopolitan:249), (4:Boris's key lime pie:268), (4:milk of magnesium:268), (4:spaghetti con calaveras:288), (4:pumpkin pie:314), (4:grimstone mask:320), (4:breakfast miracle:329), (5:perfect cosmopolitan:348), (5:perfect negroni:400), (5:perfect dark and stormy:418), (5:ninja carabiner:431), (5:ninja crampons:431), (5:ninja rope:431), (5:perfect mimosa:436), (5:ice wine:454), (5:fleetwood mac 'n' cheese:466), (5:spectral pickle:507), (5:pumpkin pie:528), (5:breakfast miracle:544), (5:hacked gibson:564), (5:antique machete:564), (5:wet stew:564), (5:blackberry galoshes:564), (5:drum machine:564), (5:killing jar:564), (5:time halo:564), (7:titanium assault umbrella:625), (7:amulet of extreme plot significance:625), (8:perfect cosmopolitan:700), (8:perfect negroni:784), (8:fleetwood mac 'n' cheese:811), (8:book of matches:833), (8:spectral pickle:853), (8:Fettris:874), (8:hacked gibson:908), (8:Hairpiece On Fire:908)
Maximizer: -tie,adv

equip hat Hairpiece On Fire
> [DEBUG] Bedtime pulls: maximizer is not equipping [time halo] into [acc1] for some reason. Skipping this slot
> [INFO] Pulling [ancient calendar] which improves desireability score by 3.0

mall.php?category=allitems&consumable_byme=0&weaponattribute=3&wearable_byme=0&nolimits=0&max_price=0&sortresultsby=price&justitems=0&x_cheapest=0&pudnuggler=%22ancient+calendar%22
> [WARNING] ancient calendar is too expensive at 396000 meat, we're gonna skip buying one in the mall.
> [WARNING] Can not pull what we don't have. Sorry
Maximizer: -tie,adv
> [DEBUG] Bedtime pulls: maximizer is not equipping [time halo] into [acc1] for some reason. Skipping this slot
> [INFO] Pulling [Mer-kin stopwatch] which improves desireability score by 3.0
mall.php?category=allitems&consumable_byme=0&weaponattribute=3&wearable_byme=0&nolimits=0&max_price=0&sortresultsby=price&justitems=0&x_cheapest=0&pudnuggler=%22Mer-kin+stopwatch%22
> [WARNING] Price of Mer-kin stopwatch may have been mall manipulated. Expected to pay at most: 1418
> [WARNING] Can not pull what we don't have. Sorry
Maximizer: -tie,adv
> [DEBUG] Bedtime pulls: maximizer is not equipping [time halo] into [acc1] for some reason. Skipping this slot
> [INFO] Pulling [Mer-kin stopwatch] which improves desireability score by 3.0

buy 1 Mer-kin stopwatch for 5200 each from shop #860584 on 20220112
> [INFO] Trying to pull 1 of Mer-kin stopwatch

pull: 1 Mer-kin stopwatch
Preference auto_pulls changed from (1:perfect cosmopolitan:83), (1:pumpkin pie:102), (1:Medical Pastaco:113), (4:perfect cosmopolitan:249), (4:Boris's key lime pie:268), (4:milk of magnesium:268), (4:spaghetti con calaveras:288), (4:pumpkin pie:314), (4:grimstone mask:320), (4:breakfast miracle:329), (5:perfect cosmopolitan:348), (5:perfect negroni:400), (5:perfect dark and stormy:418), (5:ninja carabiner:431), (5:ninja crampons:431), (5:ninja rope:431), (5:perfect mimosa:436), (5:ice wine:454), (5:fleetwood mac 'n' cheese:466), (5:spectral pickle:507), (5:pumpkin pie:528), (5:breakfast miracle:544), (5:hacked gibson:564), (5:antique machete:564), (5:wet stew:564), (5:blackberry galoshes:564), (5:drum machine:564), (5:killing jar:564), (5:time halo:564), (7:titanium assault umbrella:625), (7:amulet of extreme plot significance:625), (8:perfect cosmopolitan:700), (8:perfect negroni:784), (8:fleetwood mac 'n' cheese:811), (8:book of matches:833), (8:spectral pickle:853), (8:Fettris:874), (8:hacked gibson:908), (8:Hairpiece On Fire:908) to (1:perfect cosmopolitan:83), (1:pumpkin pie:102), (1:Medical Pastaco:113), (4:perfect cosmopolitan:249), (4:Boris's key lime pie:268), (4:milk of magnesium:268), (4:spaghetti con calaveras:288), (4:pumpkin pie:314), (4:grimstone mask:320), (4:breakfast miracle:329), (5:perfect cosmopolitan:348), (5:perfect negroni:400), (5:perfect dark and stormy:418), (5:ninja carabiner:431), (5:ninja crampons:431), (5:ninja rope:431), (5:perfect mimosa:436), (5:ice wine:454), (5:fleetwood mac 'n' cheese:466), (5:spectral pickle:507), (5:pumpkin pie:528), (5:breakfast miracle:544), (5:hacked gibson:564), (5:antique machete:564), (5:wet stew:564), (5:blackberry galoshes:564), (5:drum machine:564), (5:killing jar:564), (5:time halo:564), (7:titanium assault umbrella:625), (7:amulet of extreme plot significance:625), (8:perfect cosmopolitan:700), (8:perfect negroni:784), (8:fleetwood mac 'n' cheese:811), (8:book of matches:833), (8:spectral pickle:853), (8:Fettris:874), (8:hacked gibson:908), (8:Hairpiece On Fire:908), (8:Mer-kin stopwatch:908)
Maximizer: -tie,adv

equip off-hand Mer-kin stopwatch
> [DEBUG] Bedtime pulls: maximizer is not equipping [time halo] into [acc1] for some reason. Skipping this slot
> [INFO] Pulling [General Sage's Lonely Diamonds Club Jacket] which improves desireability score by 3.0

mall.php?category=allitems&consumable_byme=0&weaponattribute=3&wearable_byme=0&nolimits=0&max_price=0&sortresultsby=price&justitems=0&x_cheapest=0&pudnuggler=%22General+Sage%27s+Lonely+Diamonds+Club+Jacket%22

buy 1 General Sage's Lonely Diamonds Club Jacket for 270 each from shop #2218700 on 20220112
> [INFO] Trying to pull 1 of General Sage's Lonely Diamonds Club Jacket

pull: 1 General Sage's Lonely Diamonds Club Jacket
Preference auto_pulls changed from (1:perfect cosmopolitan:83), (1:pumpkin pie:102), (1:Medical Pastaco:113), (4:perfect cosmopolitan:249), (4:Boris's key lime pie:268), (4:milk of magnesium:268), (4:spaghetti con calaveras:288), (4:pumpkin pie:314), (4:grimstone mask:320), (4:breakfast miracle:329), (5:perfect cosmopolitan:348), (5:perfect negroni:400), (5:perfect dark and stormy:418), (5:ninja carabiner:431), (5:ninja crampons:431), (5:ninja rope:431), (5:perfect mimosa:436), (5:ice wine:454), (5:fleetwood mac 'n' cheese:466), (5:spectral pickle:507), (5:pumpkin pie:528), (5:breakfast miracle:544), (5:hacked gibson:564), (5:antique machete:564), (5:wet stew:564), (5:blackberry galoshes:564), (5:drum machine:564), (5:killing jar:564), (5:time halo:564), (7:titanium assault umbrella:625), (7:amulet of extreme plot significance:625), (8:perfect cosmopolitan:700), (8:perfect negroni:784), (8:fleetwood mac 'n' cheese:811), (8:book of matches:833), (8:spectral pickle:853), (8:Fettris:874), (8:hacked gibson:908), (8:Hairpiece On Fire:908), (8:Mer-kin stopwatch:908) to (1:perfect cosmopolitan:83), (1:pumpkin pie:102), (1:Medical Pastaco:113), (4:perfect cosmopolitan:249), (4:Boris's key lime pie:268), (4:milk of magnesium:268), (4:spaghetti con calaveras:288), (4:pumpkin pie:314), (4:grimstone mask:320), (4:breakfast miracle:329), (5:perfect cosmopolitan:348), (5:perfect negroni:400), (5:perfect dark and stormy:418), (5:ninja carabiner:431), (5:ninja crampons:431), (5:ninja rope:431), (5:perfect mimosa:436), (5:ice wine:454), (5:fleetwood mac 'n' cheese:466), (5:spectral pickle:507), (5:pumpkin pie:528), (5:breakfast miracle:544), (5:hacked gibson:564), (5:antique machete:564), (5:wet stew:564), (5:blackberry galoshes:564), (5:drum machine:564), (5:killing jar:564), (5:time halo:564), (7:titanium assault umbrella:625), (7:amulet of extreme plot significance:625), (8:perfect cosmopolitan:700), (8:perfect negroni:784), (8:fleetwood mac 'n' cheese:811), (8:book of matches:833), (8:spectral pickle:853), (8:Fettris:874), (8:hacked gibson:908), (8:Hairpiece On Fire:908), (8:Mer-kin stopwatch:908), (8:General Sage's Lonely Diamonds Club Jacket:908)
Maximizer: -tie,adv

equip shirt General Sage's Lonely Diamonds Club Jacket
> [DEBUG] Bedtime pulls: maximizer is not equipping [time halo] into [acc1] for some reason. Skipping this slot
> [INFO] Pulling [deadfall branch] which improves desireability score by 1.0

mall.php?category=allitems&consumable_byme=0&weaponattribute=3&wearable_byme=0&nolimits=0&max_price=0&sortresultsby=price&justitems=0&x_cheapest=0&pudnuggler=%22deadfall+branch%22
> [WARNING] deadfall branch is too expensive at 40000 meat, we're gonna skip buying one in the mall.
> [WARNING] Can not pull what we don't have. Sorry
Maximizer: -tie,adv
> [DEBUG] Bedtime pulls: maximizer is not equipping [time halo] into [acc1] for some reason. Skipping this slot
> [INFO] Pulling [chrome sword] which improves desireability score by 3.0
mall.php?category=allitems&consumable_byme=0&weaponattribute=3&wearable_byme=0&nolimits=0&max_price=0&sortresultsby=price&justitems=0&x_cheapest=0&pudnuggler=%22chrome+sword%22

buy 1 chrome sword for 210 each from shop #1053259 on 20220112
> [INFO] Trying to pull 1 of chrome sword

pull: 1 chrome sword
Preference auto_pulls changed from (1:perfect cosmopolitan:83), (1:pumpkin pie:102), (1:Medical Pastaco:113), (4:perfect cosmopolitan:249), (4:Boris's key lime pie:268), (4:milk of magnesium:268), (4:spaghetti con calaveras:288), (4:pumpkin pie:314), (4:grimstone mask:320), (4:breakfast miracle:329), (5:perfect cosmopolitan:348), (5:perfect negroni:400), (5:perfect dark and stormy:418), (5:ninja carabiner:431), (5:ninja crampons:431), (5:ninja rope:431), (5:perfect mimosa:436), (5:ice wine:454), (5:fleetwood mac 'n' cheese:466), (5:spectral pickle:507), (5:pumpkin pie:528), (5:breakfast miracle:544), (5:hacked gibson:564), (5:antique machete:564), (5:wet stew:564), (5:blackberry galoshes:564), (5:drum machine:564), (5:killing jar:564), (5:time halo:564), (7:titanium assault umbrella:625), (7:amulet of extreme plot significance:625), (8:perfect cosmopolitan:700), (8:perfect negroni:784), (8:fleetwood mac 'n' cheese:811), (8:book of matches:833), (8:spectral pickle:853), (8:Fettris:874), (8:hacked gibson:908), (8:Hairpiece On Fire:908), (8:Mer-kin stopwatch:908), (8:General Sage's Lonely Diamonds Club Jacket:908) to (1:perfect cosmopolitan:83), (1:pumpkin pie:102), (1:Medical Pastaco:113), (4:perfect cosmopolitan:249), (4:Boris's key lime pie:268), (4:milk of magnesium:268), (4:spaghetti con calaveras:288), (4:pumpkin pie:314), (4:grimstone mask:320), (4:breakfast miracle:329), (5:perfect cosmopolitan:348), (5:perfect negroni:400), (5:perfect dark and stormy:418), (5:ninja carabiner:431), (5:ninja crampons:431), (5:ninja rope:431), (5:perfect mimosa:436), (5:ice wine:454), (5:fleetwood mac 'n' cheese:466), (5:spectral pickle:507), (5:pumpkin pie:528), (5:breakfast miracle:544), (5:hacked gibson:564), (5:antique machete:564), (5:wet stew:564), (5:blackberry galoshes:564), (5:drum machine:564), (5:killing jar:564), (5:time halo:564), (7:titanium assault umbrella:625), (7:amulet of extreme plot significance:625), (8:perfect cosmopolitan:700), (8:perfect negroni:784), (8:fleetwood mac 'n' cheese:811), (8:book of matches:833), (8:spectral pickle:853), (8:Fettris:874), (8:hacked gibson:908), (8:Hairpiece On Fire:908), (8:Mer-kin stopwatch:908), (8:General Sage's Lonely Diamonds Club Jacket:908), (8:chrome sword:908)
Maximizer: -tie,adv
> [DEBUG] Bedtime pulls: maximizer is not equipping [chrome sword] into [weapon] for some reason. Skipping this slot
> [DEBUG] Bedtime pulls: maximizer is not equipping [time halo] into [acc1] for some reason. Skipping this slot
taltamir commented 2 years ago

Chrome Sword (2 handed weapon) Mer-kin stopwatch (off hand)

that is odd. it should be accounting for this limitation and avoiding doing that. So there is some error in the code

Time Halo (acc that only gives adventures if no weapon is equiped)

I didn't consider accounting for that limitation. Need to add code for doing that.

quarklikeadork commented 2 years ago

tried to add more accurate rollover_improvement when more than 1 slot is impacted, but if current weapon is 2h it is still not accurate and checks improvement of 1h over current 2h instead of improvement of 2 possible hands together (average improvement of 2 pulls, or 1 pull + best 1h/offhand in inventory) and there are other possible conflicts between ranged and melee weapons,

with current strategy time halo adds so much complexity it could be fair to just exclude it if you're not boris or Way of the Surprising Fist.