Open HippoKingKoL opened 1 year ago
The reason I'm filing this as an issue rather than a PR is that I'm not sure what to do about it. So far I've added more conditions to the dairy goat to just not olfact if you are going to have enough cheese by the end of the combat:
Dairy Goat loc:The Goatlet;item:goat cheese < 2;!itemdropcapped:40=goat cheese
But I'm not sure if this the most useful (or even a sane) way to resolve this. I'm pretty sure that logic isn't even right.
data entries is unfortunately the way to resolve, the logic is wrong because OR needs several entries
Dairy Goat loc:The Goatlet;item:goat cheese < 2
Dairy Goat loc:The Goatlet;item:goat cheese < 3;!itemdropcapped:40=goat cheese
this would quickly multiply if you added support for more things to condition, like drones
Context
Expected/Desired Behavior
Olfaction is used to encounter further copies of a monster. Since it was implemented, Polar Vortex has been added, which is a pickpocket that lets you get multiple copies of an monster's drops. This means you can vortex until you have as many items as you need from the monster, and no longer need to see any more.
Current Behavior
Right now, polar vortex happens before olfaction. This means that for monsters desired for item drops, you can extract all of the items you need before it stops using polar vortex, and then after you no longer need the monster, it will olfact it. With limited olfactions now, this may be limiting later options.
I've observed this behaviour with Goat Cheese (dairy goat) and Rusty Hedge Trimmers (topiary).
The reason I'm filing this as an issue rather than a PR is that I'm not sure what to do about it. So far I've added more conditions to the dairy goat to just not olfact if you are going to have enough cheese by the end of the combat:
Dairy Goat loc:The Goatlet;item:goat cheese < 2;!itemdropcapped:40=goat cheese
But I'm not sure if this the most useful (or even a sane) way to resolve this. I'm pretty sure that logic isn't even right.Failure Logs